New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
-[NSNull count]: unrecognized selector sent to instance 0x22d0ed7f0 #1430
Comments
Please help |
Same here! shame on you FB!! what should we do now? just wait for them to release their mistake and rollback? |
same here |
same here |
Version 7.0 same issue |
same |
same here
|
Same Issue |
Same issue here with 5.5.0 |
+1 |
Same here, more then 500K of crashes for only last 20 minutes... Is anybody from FB stuff here? It seems the same crashes we had several months ago when almost all apps were affected and not launching. |
Same issue, right where @Sanich63 shows on the screenshot |
OH COME ON! Not again! Your crash has halted Firebase crashlytics again! |
same here using |
I'm suspecting that this might be a backend related issue from FB side, because crash happens on an app that's released a month ago with no update whatsoever to FB SDK. Maybe some wrong values gets sent from their feature flag server or something, and causes crash on the client. Hope FB can roll back whatever changes quickly. |
7.0.0 is crashing, 7.1.1 seems stable |
+1 |
+1 crashing |
1 similar comment
+1 crashing |
Oh god, this is happening again, crashing to all my users |
+1 crashing |
Seems it's night in US and no one react from FB... |
Same here +1 crashing |
@apogodin must be: |
For me updating FBSDKLoginKit and FBSDKShareKit to 5.15.1 (was 5.5.0) seem to fix an issue. Please double check. |
"FacebookFix" should be in investing in ObjC developers |
@apogodin This case is raising warning in Swift |
Here’s the facebook bug page, https://developers.facebook.com/support/bugs/329763701368293/ |
pidary zaebali |
I am using 5.15.1 and it was crashing initially but now its fixed for about half an hour ago. |
FB guys; The problem seems to be happening when a NSNull object is been passed by parameter... So nullable annotation here was not enough... You will have to revisit all the library to add a if is instance of NSNull then return? 😄 |
Using anything from Facebook is considered harmful to your business, unless you are Facebook. |
I am using 5.15.1 and it was crashing initially but now its fixed for about half an hour ago. Try updating to 5.15.1. |
If to switch back to 5.5.0 for me it crashes even now( So I guess there is fix that is working for 5.15.1 (or lower?) now. |
It's also possible to swizzle |
nu 4e zato O(n) mojem |
How quickly can your app be submitted, reviewed, approved and then have users update? Before FB issues a fix? |
Seems Facebook fixed it. Can anyone confirm? |
yes |
yes fixed |
yes, it's fixed now. |
Might not be crashing, but we are unable to verify token from our backend. Guess facebook has turned if off for a while. |
You should definitely RIIR to make it more memory-safe! |
Duplicate of #1427 |
我写了一个关于这个问题的文章,包含以后此类问题的预防方法: https://blog.mzying.com/index.php/archives/231/ |
这个bug服了,OC里基本类型检查都没有 |
facebook#1439) Summary: - [x] sign [contributor license agreement](https://developers.facebook.com/opensource/cla) - [ ] I've ensured that all existing tests pass and added tests (when/where necessary) - [ ] I've updated the documentation (when/where necessary) and [Changelog](CHANGELOG.md) (when/where necessary) - [ ] I've added the proper label to this pull request (e.g. `bug` for bug fixes) ## Pull Request Details ## Issues - [1430](facebook#1430) - [1432](facebook#1432) Describe what you accomplished in this pull request (for example, what happens before the change, and after the change) 1. In my case, in the response in the `serverConfigurationRequest`, the value for `restrictive_data_filter_params` is `null`. Yes!!! `null` is a valid value in [`JSON` starndard](https://www.json.org/json-en.html). ![image](https://user-images.githubusercontent.com/7471672/87173868-f5d8c400-c308-11ea-81fd-699c5443a43e.png) 2. Then after FB using `[NSJSONSerialization JSONObjectWithData: options: error:]` to serialize this object, it returns `NSNull` object without error, which is under expectation from Apple side. According to Apple's doc, `NSNull` is a singleton object. Yes!!!, it is a valid object, not like `nil`, which you can guard using `if (obj)` statement ![image](https://user-images.githubusercontent.com/7471672/87174136-57009780-c309-11ea-9a0a-ca24369e96f9.png) 3. So, when FB try to use `if (serializedObj) { ... }` to guard this edge cases in many places, it is actually useless. Here `serializedObj` is a singleton object, the result is YES then it continues to send message, then, `unrecoginized selector` . This issue haven't been fixed. Next time, when the server side sends an another object with `null`, we will see another disaster, a third disaster. So, I made these changes for 3 reason: 1. `null` is a valid value in [`JSON` starndard](https://www.json.org/json-en.html). 2. `[NSJSONSerialization JSONObjectWithData: options: error:]` will return `NSNull` singleton object for `null` value in Object, it is under expectation. 3. There are too many places in this SDK using the result of `[NSJSONSerialization JSONObjectWithData: options: error:]` without check `NSNull`. This is could be an easier way to handle this edge case. Pull Request resolved: facebook#1439 Test Plan: **Add your test plan here** Differential Revision: D22484108 Pulled By: joesus fbshipit-source-id: 42e2c42074885e683b627b499e65a8144fdcc2b2
SDK version: iOS 6.5.2
The text was updated successfully, but these errors were encountered: